[Kde-bindings] smoke qt empty builds on macosx

Arno Rehn arno at arnorehn.de
Fri May 7 10:38:46 UTC 2010


On Friday 07 May 2010 11:19:42 Petr Vanek wrote:
> hi again,
> 
> On May 5, 2010, at 6:59 AM, Petr Vaněk wrote:
> > Yes, my solution is based on "private" variables. It's srupid. I'm
> > in contact
> > with FindQt4.cmake maintainer and we are looking for better solution.
> > 
> > It looks like it will be more complicated because of different
> > include file
> > locations in qt4 from macports and binary package. Please, wait with
> > the
> > patch, I'll suggest a better one in few days.
> 
> please look at this patch:
> http://qore.svn.sourceforge.net/viewvc/qore?view=rev&revision=3462
> 
> main changes are in smoke/qt CMakeList.txt:
> http://qore.svn.sourceforge.net/viewvc/qore/module-qt4/trunk/smoke/qt/CMake
> Lists.txt?r1=3462&r2=3461&pathrev=3462&diff_format=u
Looks good.

> it creates 2 new variables to handle mac inlcude dirs and includes.
> Then there are some tests if it's using really frameworks etc.
> 
> there is new file with includes for mac frameworks:
> 
> http://qore.svn.sourceforge.net/viewvc/qore/module-qt4/trunk/smoke/qt/qt_in
> cludes_macframework.h?diff_format=u&revision=3462&view=markup&pathrev=3462
Why do we need a different header file here? From a quick glance it appears 
that nothing's different to qt_includes.h.
If there's really anything platform-specific, try to put it directly into 
qt_includes.h. The header file has fully-fledged preprocessor support, so you 
can test for Q_OS_MAC or similar.
 
> now I'm opened to all critics and suggestions.
> I tested it on: linux (opensuse), macosx (leopard) with 1) macports
> qt4-mac package and 2) qt4 binary package from nokia too.
Good to know that it works on all those platforms. I'll probably commit a 
version without the qt_include_macframework.h.

-- 
Arno Rehn
arno at arnorehn.de



More information about the Kde-bindings mailing list