[Kde-bindings] KDE/kdebindings/generator/generators/smoke

Richard Dale rdale at foton.es
Fri Dec 18 16:46:18 UTC 2009


On Friday 18 December 2009 03:27:28 pm Arno Rehn wrote:
> SVN commit 1063443 by arnorehn:
> 
> Don't add one to the methodNames count - idMethodName() doesn't expect that
>  and might crash.
That sounds a bit 'sketchy' - do we treat the count of entries in all the 
smoke tables in the same way? Was this one out of line with the rest?

-- Richard


> CCMAIL: kde-bindings at kde.org
> 
> 
> 
>  M  +1 -1      writeSmokeDataFile.cpp
> 
> 
> --- trunk/KDE/kdebindings/generator/generators/smoke/writeSmokeDataFile.cpp
>  #1063442:1063443 @@ -675,7 +675,7 @@
>      out << "        " << smokeNamespaceName << "::classes, " << classCount
>  << ",\n"; out << "        " << smokeNamespaceName << "::methods, " <<
>  methodCount << ",\n"; out << "        " << smokeNamespaceName <<
>  "::methodMaps, " << methodMapCount << ",\n"; -    out << "        " <<
>  smokeNamespaceName << "::methodNames, " << methodNames.count() + 1 <<
>  ",\n"; +    out << "        " << smokeNamespaceName << "::methodNames, "
>  << methodNames.count() << ",\n"; out << "        " << smokeNamespaceName
>  << "::types, " << typeIndex.count() << ",\n"; out << "        " <<
>  smokeNamespaceName << "::inheritanceList,\n"; out << "        " <<
>  smokeNamespaceName << "::argumentList,\n";
>  _______________________________________________
> Kde-bindings mailing list
> Kde-bindings at kde.org
> https://mail.kde.org/mailman/listinfo/kde-bindings
> 



More information about the Kde-bindings mailing list