[Kde-accessibility] Re: [Kwin] Sizes for the window borders

[Lubos Lunak]

On Wednesday 24 of September 2003 13:12, Gunnar Schmi Dt wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hello,
>
> On Wednesday 24 September 2003 10:21, Luciano Montanaro wrote:
> > On Tuesday 23 September 2003 17:05, Gunnar Schmi Dt wrote:
> > > Hello,
> > >
> > > Just a few minutes ago I added the two decoration sizes BorderVeryHuge
> > > and BorderOversized to the list of known border sizes (as the first
> > > part of my entry "Add an option to allow wide borders to some of the
> > > window decoration styles" in the feature plan).
> >
> > OK. I am not sure about the size names. I think of Huge to be larger than
> > oversized, for example, and can you say 'very huge' in english? Maybe
> > Enormous, or Gargantuan, or something is better. Maybe simply "largest"
> > could do.
>
> Well, the fact that the names don't reflect the sizes very well came to my
> mind, too, after I saw how they look like: The "large" border isn't really
> large when you compare it with sizes as "Huge" or "Oversized". The problem
> is that the second-smallest size is called "Normal".
>
> Maybe we can rename the sizes a little bit:
>
> BorderTiny
> BorderSmall (was BorderNormal, this is the default one)
> BorderMedium (wasBorderLarge)
> BorderLarge (was BorderVeryLarge)
> BorderVeryLarge (was BorderHuge)
> BorderHuge (wasBorderVeryHuge)
> BorderLargest (was BorderOversized)

 The second smallest is called Normal, because it is the normal. I don't care 
how many and how named other options are there, but the default one should be 
called so.

[snip]
> That sounds good, so I do not need to look into those decorations. From the
> currently ported decorations there are KDE2, Keramik, ModSystem, Quartz,
> and Redmond left. I will look into these. (I have already started with the
> KDE2 decoration.)
>
> > > Currently the KCM for the window decoration does not allow to set the
> > > border size. However, I have prepared a patch that adds a combo box for
> > > the sizes to that KCM. This patch is a quick hack (it does not check
> > > whether the actual decoration supports different border sizes), but it
> > > works. Is it OK to commit that patch until we have a clean solution for
> > > the GUI?

 No. I have a better patch that checks which sizes the decoration supports 
(already in CVS). It still could use some aestethical polish though.

 The new API for this is KDecorationFactory::borderSizes() . I've updated the 
Web decoration already.

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/