[Kde-accessibility] kmag issues

Olaf Jan Schmidt olaf@amen-online.de
Fri, 24 Jan 2003 00:05:19 +0100


--------------Boundary-00=_V4W6AUYWCLZKVI5IZ99A
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Sarang!

During the last days, I tested the three applications in kdeaccessibility=
=20
to search for possible improvements.

I found three problems with kmag:

1. The file menu in kmag is empty. A patch is attached.
2. kdeaccessibility/kmag/templates should be removed.

Is it OK if I commit these two changes?

3. I thought kmag was buggy because it did allow me to magnify the edge o=
f=20
screen after i changes the ratio, but it is rather a usability problem.

It took me quite a while to find out that you need to click onto "maximiz=
e=20
the use of the window" whenever you change the window size or the=20
magifier ratio.=20

Are there any strong reasons for not always using the correct window size=
?=20
If so, then we should ask kde-usability for advice, otherwise we could=20
just remove that button and make it adjust automatically.

Olaf.

- --=20
Olaf Jan Schmidt, KDE Accessibility Project
KDEAP co-maintainer, maintainer of http://accessibility.kde.org

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iEYEARECAAYFAj4wdS8ACgkQoLYC8AehV8dpoACgy58A6a6030NVIzG0FWHM1OSX
TDEAnilG9M7yjXoElRCEW+rRmWkHAUXa
=3Dmqag
-----END PGP SIGNATURE-----

--------------Boundary-00=_V4W6AUYWCLZKVI5IZ99A
Content-Type: text/x-diff;
  charset="us-ascii";
  name="kmag.cpp.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="kmag.cpp.diff"

Index: kmag/kmag.cpp
===================================================================
RCS file: /home/kde/kdeaccessibility/kmag/kmag.cpp,v
retrieving revision 1.30
diff -u -3 -p -r1.30 kmag.cpp
--- kmag/kmag.cpp	22 Jan 2003 19:37:06 -0000	1.30
+++ kmag/kmag.cpp	23 Jan 2003 22:55:31 -0000
@@ -121,7 +121,7 @@ KmagApp::~KmagApp()
 void KmagApp::initActions()
 {
   fileNewWindow = new KAction(i18n("New &Window"), "window_new", KStdAccel::key(KStdAccel::New), this,
-															SLOT(slotFileNewWindow()), actionCollection(),"new_window");
+															SLOT(slotFileNewWindow()), actionCollection(),"file_new_window");
   fileNewWindow->setToolTip(i18n("Open a new KMagnifier window"));
 
 	refreshSwitch = new KAction(i18n("Stop"), "stop", KStdAccel::key(KStdAccel::Reload), this,

--------------Boundary-00=_V4W6AUYWCLZKVI5IZ99A--