Review Request 128651: avoid crash on reading DVD titles

Martin Koller kollix at aon.at
Thu Aug 11 08:21:58 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128651/
-----------------------------------------------------------

(Updated Aug. 11, 2016, 10:21 a.m.)


Status
------

This change has been marked as submitted.


Review request for K3b.


Changes
-------

Submitted with commit 1eafece6efa2b7f52460fbdb7ca86c7d41c5c898 by Martin Koller to branch kf5.


Repository: k3b


Description
-------

On trying to rip a DVD k3b crashed for me.
Analyzing the reason, I found out that one track of the DVD does not contain any chapter
or at least libdvdread complains with:

*** libdvdread: CHECK_VALUE failed in src/ifo_read.c:905 ***
*** for pgc->cell_playback_offset != 0 ***

This patch avoids the crash by removing any title information which does not contain any chapter.


Diffs
-----

  libk3b/videodvd/k3bvideodvd.cpp 0d5a2e8 

Diff: https://git.reviewboard.kde.org/r/128651/diff/


Testing
-------

Loaded and ripped the DVD successfully


Thanks,

Martin Koller

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20160811/d84b8dc1/attachment-0001.html>


More information about the k3b mailing list