Review Request 128651: avoid crash on reading DVD titles

[Leslie Zhai]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128651/#review98309
-----------------------------------------------------------


Ship it!




Hi Martin,

Thanks for your patch!

K3b will be merged kf5 branch after August 12 https://mail.kde.org/pipermail/release-team/2016-July/009628.html so please test the patch for kf5 branch too, and I tested it, it is OK to me :-) but I hold the view that you also need to test it, thanks a lot!

And if you have KDE Developers' identity, please git push to kf5 branch, thanks again!

Regards,
Leslie Zhai

- Leslie Zhai


On 八月 11, 2016, 1:34 a.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128651/
> -----------------------------------------------------------
> 
> (Updated 八月 11, 2016, 1:34 a.m.)
> 
> 
> Review request for K3b.
> 
> 
> Repository: k3b
> 
> 
> Description
> -------
> 
> On trying to rip a DVD k3b crashed for me.
> Analyzing the reason, I found out that one track of the DVD does not contain any chapter
> or at least libdvdread complains with:
> 
> *** libdvdread: CHECK_VALUE failed in src/ifo_read.c:905 ***
> *** for pgc->cell_playback_offset != 0 ***
> 
> This patch avoids the crash by removing any title information which does not contain any chapter.
> 
> 
> Diffs
> -----
> 
>   libk3b/videodvd/k3bvideodvd.cpp 0d5a2e8 
> 
> Diff: https://git.reviewboard.kde.org/r/128651/diff/
> 
> 
> Testing
> -------
> 
> Loaded and ripped the DVD successfully
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20160811/39eddf1b/attachment.html>