[k3b] Review Request 123431: kf5: Fix build failure when compiling with GCC 5

Armin K. krejzi at email.com
Sun May 3 22:01:25 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123431/
-----------------------------------------------------------

(Updated May 3, 2015, 10:01 p.m.)


Status
------

This change has been marked as submitted.


Review request for K3b, Albert Astals Cid and Michal Malek.


Changes
-------

Submitted with commit d5b1016e6a4c1dfcf681ce33ea9ffdd0dd5daf24 by Albert Astals Cid on behalf of Armin K to branch kf5.


Repository: k3b


Description
-------

When building with GCC 5, the compiler will complain about narrowing conversions inside { } and fail. The patch fixes the build with GCC 5, at least for me. I was given hint by thiago on #kde-devel to use unsigned char, but I have another patch version where I used int. Both seem to work fine.


Diffs
-----

  libk3b/projects/k3bcdrdaowriter.cpp 0d14408 
  libk3b/tools/k3bwavefilewriter.cpp 7aa6c1d 
  plugins/encoder/external/k3bexternalencoder.cpp df9c576 

Diff: https://git.reviewboard.kde.org/r/123431/diff/


Testing
-------


Thanks,

Armin K.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20150503/66b6b07f/attachment.html>


More information about the k3b mailing list