[k3b] Review Request 123431: kf5: Fix build failure when compiling with GCC 5

Armin K. krejzi at email.com
Sun May 3 15:35:44 UTC 2015



> On May 3, 2015, 2:44 p.m., Albert Astals Cid wrote:
> >

I don't have commit access, so could you please commit it for me?


- Armin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123431/#review79796
-----------------------------------------------------------


On April 19, 2015, 7:30 p.m., Armin K. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123431/
> -----------------------------------------------------------
> 
> (Updated April 19, 2015, 7:30 p.m.)
> 
> 
> Review request for K3b, Albert Astals Cid and Michal Malek.
> 
> 
> Repository: k3b
> 
> 
> Description
> -------
> 
> When building with GCC 5, the compiler will complain about narrowing conversions inside { } and fail. The patch fixes the build with GCC 5, at least for me. I was given hint by thiago on #kde-devel to use unsigned char, but I have another patch version where I used int. Both seem to work fine.
> 
> 
> Diffs
> -----
> 
>   libk3b/projects/k3bcdrdaowriter.cpp 0d14408 
>   libk3b/tools/k3bwavefilewriter.cpp 7aa6c1d 
>   plugins/encoder/external/k3bexternalencoder.cpp df9c576 
> 
> Diff: https://git.reviewboard.kde.org/r/123431/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Armin K.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20150503/8f1d650b/attachment.html>


More information about the k3b mailing list