[k3b] Review Request 120400: Make paranoia lib detection better.

[Johannes Obermayr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120400/
-----------------------------------------------------------

Review request for K3b.


Repository: k3b


Description
-------

Before it checked first for old cdda interface and provide new cdio interface as fallback.

That implementation was buggy:
What happened if cdda interface was found but the new cdio interface failed?

        ... cdio interface checks ...

        // try the new cdio lib
        if( s_libInterface == 0 ) {
            s_libInterface = dlopen( LIBCDIO_CDDA, RTLD_NOW|RTLD_GLOBAL );
            s_haveLibCdio = true;
        }

        if( s_libInterface == 0 ) {
            kDebug() << "(K3b::CdparanoiaLib) Error while loading libcdda_interface. ";
            return 0;
        }

Yes, dlopen returned 0 and the next check returned an error.

Now it checks first for new cdio interface and provide old cdda interface as fallback.

It also supports new *.so.2:
https://github.com/rocky/libcdio-paranoia/commit/ed0ec1a


Diffs
-----

  libk3b/tools/k3bcdparanoialib.cpp 68e2284 

Diff: https://git.reviewboard.kde.org/r/120400/diff/


Testing
-------


Thanks,

Johannes Obermayr

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20140928/e3e34217/attachment.html>