<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120400/">https://git.reviewboard.kde.org/r/120400/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for K3b.</div>
<div>By Johannes Obermayr.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
k3b
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Before it checked first for old cdda interface and provide new cdio interface as fallback.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That implementation was buggy:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
What happened if cdda interface was found but the new cdio interface failed?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"> ... cdio interface checks ...
<span style="color: #408080; font-style: italic">// try the new cdio lib</span>
<span style="color: #008000; font-weight: bold">if</span>( s_libInterface <span style="color: #666666">==</span> <span style="color: #666666">0</span> ) {
s_libInterface <span style="color: #666666">=</span> dlopen( LIBCDIO_CDDA, RTLD_NOW<span style="color: #666666">|</span>RTLD_GLOBAL );
s_haveLibCdio <span style="color: #666666">=</span> <span style="color: #008000">true</span>;
}
<span style="color: #008000; font-weight: bold">if</span>( s_libInterface <span style="color: #666666">==</span> <span style="color: #666666">0</span> ) {
kDebug() <span style="color: #666666"><<</span> <span style="color: #BA2121">"(K3b::CdparanoiaLib) Error while loading libcdda_interface. "</span>;
<span style="color: #008000; font-weight: bold">return</span> <span style="color: #666666">0</span>;
}
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, dlopen returned 0 and the next check returned an error.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now it checks first for new cdio interface and provide old cdda interface as fallback.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It also supports new *.so.2:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
https://github.com/rocky/libcdio-paranoia/commit/ed0ec1a</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libk3b/tools/k3bcdparanoialib.cpp <span style="color: grey">(68e2284)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120400/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>