[k3b] Review Request 120459: Use QElapsedTimer to calculate remaining time

Johannes Obermayr johannesobermayr at gmx.de
Sat Oct 18 15:29:52 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120459/
-----------------------------------------------------------

(Updated Okt. 18, 2014, 5:29 nachm.)


Review request for K3b.


Changes
-------

- turned into a QElapsedTimer (not a pointer to it)
- context change is to sync with master
- remove m_timer.start() // m_timer.restart() construct
- "Remaining time: %1" calculation is now in a single line for easier reading. I don't want to move it outside setText to save one variable ...
- now also tested on 2.0 branch


Bugs: 330239
    http://bugs.kde.org/show_bug.cgi?id=330239


Repository: k3b


Description
-------

Qt 4.7 release was on 2010-09-21 (4 years ago). IMHO we can force it for 2.0.3 ...


Diffs (updated)
-----

  src/k3bjobprogressdialog.cpp 1890ccf 
  CMakeLists.txt e467321 
  src/k3bjobprogressdialog.h 224a5a5 

Diff: https://git.reviewboard.kde.org/r/120459/diff/


Testing
-------

successful on master


Thanks,

Johannes Obermayr

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20141018/077f68af/attachment.html>


More information about the k3b mailing list