[k3b] Review Request 120459: Use QElapsedTimer to calculate remaining time

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120459/#review68022
-----------------------------------------------------------



src/k3bjobprogressdialog.cpp
<https://git.reviewboard.kde.org/r/120459/#comment47411>

    You are leaking m_timer. I'd just turn it into a QElapsedTimer instead of a QElapsedTimer pointer.



src/k3bjobprogressdialog.cpp
<https://git.reviewboard.kde.org/r/120459/#comment47412>

    Why the new context?



src/k3bjobprogressdialog.cpp
<https://git.reviewboard.kde.org/r/120459/#comment47413>

    I don't understand this construct, why not just restart only?



src/k3bjobprogressdialog.cpp
<https://git.reviewboard.kde.org/r/120459/#comment47414>

    I liked it more when the remainingSecs calculation was outside the setText, easier to read.


- Albert Astals Cid


On oct. 2, 2014, 6:58 a.m., Johannes Obermayr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120459/
> -----------------------------------------------------------
> 
> (Updated oct. 2, 2014, 6:58 a.m.)
> 
> 
> Review request for K3b.
> 
> 
> Bugs: 330239
>     http://bugs.kde.org/show_bug.cgi?id=330239
> 
> 
> Repository: k3b
> 
> 
> Description
> -------
> 
> Qt 4.7 release was on 2010-09-21 (4 years ago). IMHO we can force it for 2.0.3 ...
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e467321 
>   src/k3bjobprogressdialog.h 224a5a5 
>   src/k3bjobprogressdialog.cpp 1890ccf 
> 
> Diff: https://git.reviewboard.kde.org/r/120459/diff/
> 
> 
> Testing
> -------
> 
> successful on master
> 
> 
> Thanks,
> 
> Johannes Obermayr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20141006/5b675bad/attachment.html>