[k3b] Review Request 120607: Fix Crash while remove songs in "Mixed mode CD proyect"

[Michal Malek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120607/#review68576
-----------------------------------------------------------

Ship it!


I think the patch is ok, thanks!

- Michal Malek


On Paź 16, 2014, 3:55 po południu, Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120607/
> -----------------------------------------------------------
> 
> (Updated Paź 16, 2014, 3:55 po południu)
> 
> 
> Review request for K3b.
> 
> 
> Bugs: 323117
>     http://bugs.kde.org/show_bug.cgi?id=323117
> 
> 
> Repository: k3b
> 
> 
> Description
> -------
> 
> It happens that the first remove of song deletes the parent model so the rest of subsequent removes go back to the parent model, try to delete themselves from it and they are already gone.
> 
> 
> Diffs
> -----
> 
>   src/k3bmetaitemmodel.cpp 8101596 
> 
> Diff: https://git.reviewboard.kde.org/r/120607/diff/
> 
> 
> Testing
> -------
> 
> Create a mixed mode CD.
> 
> Add three songs to the audio section
> Select two songs
> Remove them
> 
> Without the patch it crashes, with it works fine
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20141016/e5c80e0d/attachment.html>