[k3b] Review Request 120607: Fix Crash while remove songs in "Mixed mode CD proyect"

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120607/#review68562
-----------------------------------------------------------


The code change and explanation makes sense to me. I'll let the maintainers decide ship it or not though as I'm not familiar with the code itself.

- Jeremy Whiting


On Oct. 16, 2014, 9:55 a.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120607/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 9:55 a.m.)
> 
> 
> Review request for K3b.
> 
> 
> Bugs: 323117
>     http://bugs.kde.org/show_bug.cgi?id=323117
> 
> 
> Repository: k3b
> 
> 
> Description
> -------
> 
> It happens that the first remove of song deletes the parent model so the rest of subsequent removes go back to the parent model, try to delete themselves from it and they are already gone.
> 
> 
> Diffs
> -----
> 
>   src/k3bmetaitemmodel.cpp 8101596 
> 
> Diff: https://git.reviewboard.kde.org/r/120607/diff/
> 
> 
> Testing
> -------
> 
> Create a mixed mode CD.
> 
> Add three songs to the audio section
> Select two songs
> Remove them
> 
> Without the patch it crashes, with it works fine
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20141016/4d57e0d1/attachment.html>