[k3b] Review Request 110230: Inform the user if the inserted medium is not suitable

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110230/
-----------------------------------------------------------

(Updated May 3, 2013, 7:55 a.m.)


Status
------

This change has been marked as submitted.


Review request for K3b.


Description
-------

In the burn dialog, the message displayed when an incorrect medium was inserted was the same that the one when there was no medium inserted. As a result, the user might think that there's a problem with the device instead of a problem with the medium.

If there's a medium inserted on a device but it's no suitable (for example if it's a CD and it should be a DVD, or if it's a read-only medium, or if the capacity of the medium is not enough), the user will be informed of the reason of the issue.

mediaRequestStrings added as a static method to Medium class. This method takes as parameters a list of unsuitable mediums and the requeriments for a medium to be suitable and returns a QStringList with messages describing the problem of each unsuitable medium.

MediaSelectionComboBox was modified to call mediaRequestStrings when a medium is inserted but is not suitable.


This addresses bug 259761.
    http://bugs.kde.org/show_bug.cgi?id=259761


Diffs
-----

  libk3b/tools/k3bmedium.h 0a7ed1a 
  libk3b/tools/k3bmedium.cpp 1ef3917 
  src/k3bmediaselectioncombobox.h ffea140 
  src/k3bmediaselectioncombobox.cpp defcbf8 

Diff: http://git.reviewboard.kde.org/r/110230/diff/


Testing
-------


File Attachments
----------------

Message when a CD is needed but a DVD is present
  http://git.reviewboard.kde.org/media/uploaded/files/2013/04/28/img3.png
Message when the capacity of the disk is not enough
  http://git.reviewboard.kde.org/media/uploaded/files/2013/04/28/img1.png
A rewritable medium is required but the inserted medium is not rewritable
  http://git.reviewboard.kde.org/media/uploaded/files/2013/04/28/img2.png


Thanks,

José Millán Soto

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20130503/a8a04062/attachment.html>