<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110230/">http://git.reviewboard.kde.org/r/110230/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for K3b.</div>
<div>By José Millán Soto.</div>
<p style="color: grey;"><i>Updated May 3, 2013, 7:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In the burn dialog, the message displayed when an incorrect medium was inserted was the same that the one when there was no medium inserted. As a result, the user might think that there's a problem with the device instead of a problem with the medium.
If there's a medium inserted on a device but it's no suitable (for example if it's a CD and it should be a DVD, or if it's a read-only medium, or if the capacity of the medium is not enough), the user will be informed of the reason of the issue.
mediaRequestStrings added as a static method to Medium class. This method takes as parameters a list of unsuitable mediums and the requeriments for a medium to be suitable and returns a QStringList with messages describing the problem of each unsuitable medium.
MediaSelectionComboBox was modified to call mediaRequestStrings when a medium is inserted but is not suitable.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=259761">259761</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libk3b/tools/k3bmedium.h <span style="color: grey">(0a7ed1a)</span></li>
<li>libk3b/tools/k3bmedium.cpp <span style="color: grey">(1ef3917)</span></li>
<li>src/k3bmediaselectioncombobox.h <span style="color: grey">(ffea140)</span></li>
<li>src/k3bmediaselectioncombobox.cpp <span style="color: grey">(defcbf8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110230/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/28/img3.png">Message when a CD is needed but a DVD is present</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/28/img1.png">Message when the capacity of the disk is not enough</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/28/img2.png">A rewritable medium is required but the inserted medium is not rewritable</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>