[k3b] Review Request 106153: CMake checks for FFmpeg API changes

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106153/#review29447
-----------------------------------------------------------


This review has been submitted with commit d27648fc8946735913176dff0c497c806f63dc8a by Alex Merry to branch master.

- Commit Hook


On Sept. 25, 2012, 7:01 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106153/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2012, 7:01 p.m.)
> 
> 
> Review request for K3b.
> 
> 
> Description
> -------
> 
> CMake checks for FFmpeg API changes
> 
> FFmpeg breaks bc every so often.  The safest way to deal with this is
> with CMake checks for the new API.  This implements such checks for most
> of the recent changes and deprecations (one function that is deprecated
> in ffmpeg 0.11 remains).
> 
> This simplifies the code considerably, at the expense of complicating CMakeLists.txt a little.
> 
> There is one remaining deprecated function: avcode_decode_audio3, which is replaced by avcode_decode_audio4.  However, this produces output in quite a different format, so the change would be more invasive.
> 
> The FFMPEG_CODEC macro changes are a separate commit, and so easy to drop if necessary.
> 
> 
> Diffs
> -----
> 
>   config-k3b.h.cmake 50c4a999fa58bbcdf4624ad9c04c05ef04a74b9d 
>   plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp 024c18ca36adc96edb5824b8efa9853634bf2528 
>   CMakeLists.txt e42568df47b9501cc3da69501097b7c298490231 
> 
> Diff: http://git.reviewboard.kde.org/r/106153/diff/
> 
> 
> Testing
> -------
> 
> Builds with FFmpeg 0.11 on ArchLinux and FFmpeg 0.7 on Fedora 15.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20130318/a716c590/attachment.html>