<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106153/">http://git.reviewboard.kde.org/r/106153/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit d27648fc8946735913176dff0c497c806f63dc8a by Alex Merry to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 25th, 2012, 7:01 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for K3b.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Sept. 25, 2012, 7:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">CMake checks for FFmpeg API changes
FFmpeg breaks bc every so often. The safest way to deal with this is
with CMake checks for the new API. This implements such checks for most
of the recent changes and deprecations (one function that is deprecated
in ffmpeg 0.11 remains).
This simplifies the code considerably, at the expense of complicating CMakeLists.txt a little.
There is one remaining deprecated function: avcode_decode_audio3, which is replaced by avcode_decode_audio4. However, this produces output in quite a different format, so the change would be more invasive.
The FFMPEG_CODEC macro changes are a separate commit, and so easy to drop if necessary.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds with FFmpeg 0.11 on ArchLinux and FFmpeg 0.7 on Fedora 15.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>config-k3b.h.cmake <span style="color: grey">(50c4a999fa58bbcdf4624ad9c04c05ef04a74b9d)</span></li>
<li>plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp <span style="color: grey">(024c18ca36adc96edb5824b8efa9853634bf2528)</span></li>
<li>CMakeLists.txt <span style="color: grey">(e42568df47b9501cc3da69501097b7c298490231)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106153/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>