[k3b] Re: Review Request: Use QLibrary instead of dlopen directly

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101038/#review2427
-----------------------------------------------------------

Ship it!


The patch looks good, it compiles on linux, and audio CD ripping works fine.

- Sebastian


On April 6, 2011, 4:16 a.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101038/
> -----------------------------------------------------------
> 
> (Updated April 6, 2011, 4:16 a.m.)
> 
> 
> Review request for K3b.
> 
> 
> Summary
> -------
> 
> This commit makes K3b use QLibrary to read symbols from the cdparanoia and libdvdcss libs instead of using dlopen+dlsym+dlclose directly. The current code has a big hack to make dlopen work as expected on Windows.
> 
> Additionally, the libraries are unloaded in some error cases in which they were not, and we only look for "libdvdcss.so" on Unix instead of hardcoding the "2" major number (it is "3" on FreeBSD, for example).
> 
> Last but not least, the checks for the cdparanoia libraries in "RedHat & co." systems has been removed, as it was causing problems with QLibrary and "cdda/" directory in /usr/lib does not seem to be present anymore in any system.
> 
> 
> Diffs
> -----
> 
>   libk3b/CMakeLists.txt 93eea44 
>   libk3b/tools/k3bcdparanoialib.h 653ffe1 
>   libk3b/tools/k3bcdparanoialib.cpp 73a6c0a 
>   libk3b/tools/k3blibdvdcss.h 720271e 
>   libk3b/tools/k3blibdvdcss.cpp c5d7c7d 
> 
> Diff: http://git.reviewboard.kde.org/r/101038/diff
> 
> 
> Testing
> -------
> 
> More testing (or tips on how to test) would be appreciated. I chose "Rip Video DVD" in the main screen, and K3b did not complain about libdvdcss symbols missing.
> 
> It would be good if this could be tested on Linux/Windows (I've tested it on FreeBSD), especially the cdparanoia part.
> 
> 
> Thanks,
> 
> Raphael
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20110406/a9cce529/attachment.html>