<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101038/">http://git.reviewboard.kde.org/r/101038/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch looks good, it compiles on linux, and audio CD ripping works fine.</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On April 6th, 2011, 4:16 a.m., Raphael Kubo da Costa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for K3b.</div>
<div>By Raphael Kubo da Costa.</div>
<p style="color: grey;"><i>Updated April 6, 2011, 4:16 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This commit makes K3b use QLibrary to read symbols from the cdparanoia and libdvdcss libs instead of using dlopen+dlsym+dlclose directly. The current code has a big hack to make dlopen work as expected on Windows.
Additionally, the libraries are unloaded in some error cases in which they were not, and we only look for "libdvdcss.so" on Unix instead of hardcoding the "2" major number (it is "3" on FreeBSD, for example).
Last but not least, the checks for the cdparanoia libraries in "RedHat & co." systems has been removed, as it was causing problems with QLibrary and "cdda/" directory in /usr/lib does not seem to be present anymore in any system.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">More testing (or tips on how to test) would be appreciated. I chose "Rip Video DVD" in the main screen, and K3b did not complain about libdvdcss symbols missing.
It would be good if this could be tested on Linux/Windows (I've tested it on FreeBSD), especially the cdparanoia part.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libk3b/CMakeLists.txt <span style="color: grey">(93eea44)</span></li>
<li>libk3b/tools/k3bcdparanoialib.h <span style="color: grey">(653ffe1)</span></li>
<li>libk3b/tools/k3bcdparanoialib.cpp <span style="color: grey">(73a6c0a)</span></li>
<li>libk3b/tools/k3blibdvdcss.h <span style="color: grey">(720271e)</span></li>
<li>libk3b/tools/k3blibdvdcss.cpp <span style="color: grey">(c5d7c7d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101038/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>