Review Request 126437: Convert Profile away from the deprecated KSharedPtr
Shlomi Fish
shlomif at shlomifish.org
Sat Jan 21 18:14:09 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126437/
-----------------------------------------------------------
(Updated Jan. 21, 2017, 6:14 p.m.)
Status
------
This change has been discarded.
Review request for Gwenview.
Repository: gwenview
Description
-------
This converts Profile away from KSharedPtr which is deprecated in KF5. It eliminates some warnings. There is another instance of KSharedPtr in gwenview which I have had more difficulty converting.
Diffs
-----
lib/cms/cmsprofile.h 17cee19
tests/auto/cmsprofiletest.cpp f59c931
Diff: https://git.reviewboard.kde.org/r/126437/diff/
Testing
-------
I ran ./app/gwenview and everything mostly seems fine. I discovered a small bug in gwenview in the process but it seems to be in
the gwenview from Mageia as well.
Thanks,
Shlomi Fish
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20170121/edf6c0c9/attachment.html>
More information about the Gwenview-devel
mailing list