Review Request 126437: Convert Profile away from the deprecated KSharedPtr

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126437/#review102122
-----------------------------------------------------------



Doesn't apply anymore

- Albert Astals Cid


On Dec. 20, 2015, 8:33 p.m., Shlomi Fish wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126437/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2015, 8:33 p.m.)
> 
> 
> Review request for Gwenview.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> This converts Profile away from KSharedPtr which is deprecated in KF5. It eliminates some warnings. There is another instance of KSharedPtr in gwenview which I have had more difficulty converting.
> 
> 
> Diffs
> -----
> 
>   lib/cms/cmsprofile.h 17cee19 
>   tests/auto/cmsprofiletest.cpp f59c931 
> 
> Diff: https://git.reviewboard.kde.org/r/126437/diff/
> 
> 
> Testing
> -------
> 
> I ran ./app/gwenview and everything mostly seems fine. I discovered a small bug in gwenview in the process but it seems to be in 
> the gwenview from Mageia as well.
> 
> 
> Thanks,
> 
> Shlomi Fish
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20170120/bc1f484b/attachment.html>