Review Request 129004: Offer to install kipi if it is not installed

Jonathan Riddell jr at jriddell.org
Wed Sep 28 14:10:33 UTC 2016



> On Sept. 28, 2016, 12:19 p.m., Harald Sitter wrote:
> > I agree with Aleix that this should use the appstream uri handle to save code (i.e. bugs), dependencies, and look nicer over all.
> > 
> > We have a wheel already. Use it.

As discussed, I'm not sure this would make it any easier to program, it would still need a file watch and reload the plugins when it worked out the plugins were available.  Maybe there are some distros who use Packagekit and not Plasma Discover I'm not sure.  It's not as integrated for the user, it's a different application which could get lost rather than a modal dialog.  The main reason I've not coded it yet to try it is currently kipi-plugins can't be installed in Plasma Discover, at least in neon, it gives an error when trying "Dependency resolution failed".


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129004/#review99625
-----------------------------------------------------------


On Sept. 26, 2016, 4:49 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129004/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2016, 4:49 p.m.)
> 
> 
> Review request for Gwenview and Aleix Pol Gonzalez.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> Use Appstream and Packagekit to offer to install Kipi plugins if they are not already installed
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 82b219a 
>   app/CMakeLists.txt ed77d7c 
>   app/kipiinterface.h 1c06cd4 
>   app/kipiinterface.cpp 04dccb3 
> 
> Diff: https://git.reviewboard.kde.org/r/129004/diff/
> 
> 
> Testing
> -------
> 
> compile without appstream/packagekit, works same as before
> compile with them it adds a menu entry to install it.  This pops up a progressdialog while packagekit installs it.  on install the menu gets reloaded with new plugins
> (note this doesn't work on neon currently because libkipi-data installs the dummy test plugins so it considers kipi-plugins to be installed, delete those before trying)
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20160928/f038b7cc/attachment.html>


More information about the Gwenview-devel mailing list