Review Request 129004: Offer to install kipi if it is not installed

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129004/#review99625
-----------------------------------------------------------



I agree with Aleix that this should use the appstream uri handle to save code (i.e. bugs), dependencies, and look nicer over all.

We have a wheel already. Use it.

- Harald Sitter


On Sept. 26, 2016, 4:49 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129004/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2016, 4:49 p.m.)
> 
> 
> Review request for Gwenview and Aleix Pol Gonzalez.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> Use Appstream and Packagekit to offer to install Kipi plugins if they are not already installed
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 82b219a 
>   app/CMakeLists.txt ed77d7c 
>   app/kipiinterface.h 1c06cd4 
>   app/kipiinterface.cpp 04dccb3 
> 
> Diff: https://git.reviewboard.kde.org/r/129004/diff/
> 
> 
> Testing
> -------
> 
> compile without appstream/packagekit, works same as before
> compile with them it adds a menu entry to install it.  This pops up a progressdialog while packagekit installs it.  on install the menu gets reloaded with new plugins
> (note this doesn't work on neon currently because libkipi-data installs the dummy test plugins so it considers kipi-plugins to be installed, delete those before trying)
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20160928/46786e90/attachment.html>