Review Request 126437: Convert Profile away from the deprecated KSharedPtr
Aurélien Gâteau
agateau at kde.org
Wed Jan 6 22:19:02 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126437/#review90717
-----------------------------------------------------------
Ship it!
Ship It!
- Aurélien Gâteau
On déc. 20, 2015, 9:33 après-midi, Shlomi Fish wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126437/
> -----------------------------------------------------------
>
> (Updated déc. 20, 2015, 9:33 après-midi)
>
>
> Review request for Gwenview.
>
>
> Repository: gwenview
>
>
> Description
> -------
>
> This converts Profile away from KSharedPtr which is deprecated in KF5. It eliminates some warnings. There is another instance of KSharedPtr in gwenview which I have had more difficulty converting.
>
>
> Diffs
> -----
>
> lib/cms/cmsprofile.h 17cee19
> tests/auto/cmsprofiletest.cpp f59c931
>
> Diff: https://git.reviewboard.kde.org/r/126437/diff/
>
>
> Testing
> -------
>
> I ran ./app/gwenview and everything mostly seems fine. I discovered a small bug in gwenview in the process but it seems to be in
> the gwenview from Mageia as well.
>
>
> Thanks,
>
> Shlomi Fish
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20160106/6782d5be/attachment.html>
More information about the Gwenview-devel
mailing list