Review Request 125216: Fix reading the ui.rc and as a result fix the UI.

Luigi Toscano luigi.toscano at tiscali.it
Sat Oct 10 14:00:43 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125216/#review86633
-----------------------------------------------------------


This review reverted the original change; a more general fix which kept the change was proposed in https://git.reviewboard.kde.org/r/125524/ and applied. This review can be now discarded.

- Luigi Toscano


On Ott. 7, 2015, 11:01 p.m., Shlomi Fish wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125216/
> -----------------------------------------------------------
> 
> (Updated Ott. 7, 2015, 11:01 p.m.)
> 
> 
> Review request for Gwenview and Ivan Čukić.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> Fix reading the ui.rc file - without it, most of the UI is missing.
> 
> 
> Diffs
> -----
> 
>   app/main.cpp 806fcab 
> 
> Diff: https://git.reviewboard.kde.org/r/125216/diff/
> 
> 
> Testing
> -------
> 
> See https://bugs.kde.org/show_bug.cgi?id=352622 - gwenview seems to run fine and much better with this patch. I tried running rotate, rescale and crop - all are working fine.
> 
> 
> Thanks,
> 
> Shlomi Fish
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20151010/638dfbd0/attachment.html>


More information about the Gwenview-devel mailing list