Review Request 123906: Fix for "Some images rotated via EXIF are not rotated and appear in the wrong size" - BUG 343044

[Martin Kyral]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123906/#review80853
-----------------------------------------------------------


I'm just wondering: is there really a need of fixing the issue when it affects just builds against 2 minor versions of Qt? See https://git.reviewboard.kde.org/r/122873/

Apart from that, the change in this review most likely breaks rotation for some of the jpeg images. Try test with these: https://github.com/recurser/exif-orientation-examples.git

Third point is that IMHO no distro shall ship gwenview 5 now because (due to missing libkipi and libkdraw kf5 versions) it is missing support for viewing RAW files.

- Martin Kyral


On Kvě. 26, 2015, 3:51 dop., Lukas Hetzenecker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123906/
> -----------------------------------------------------------
> 
> (Updated Kvě. 26, 2015, 3:51 dop.)
> 
> 
> Review request for Gwenview.
> 
> 
> Bugs: 343044
>     http://bugs.kde.org/show_bug.cgi?id=343044
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> I tracked down this bug and made the following observations:
> 
> It was caused by QTBUG-37946 ( https://bugreports.qt.io/browse/QTBUG-37946 ):
> 
> Starting with Qt 5.4 (which Ubuntu and Arch are shipping), QImage automatically checks if there is an Exif header present and rotates the images accordingly. - see this change: https://codereview.qt-project.org/#/c/98013/
> 
> But this behavior will be reverted in the soon released Qt 5.4.2, because it is backwards incompatible and breaks existing applications (like this one here ;) ) - see this change: https://codereview.qt-project.org/#/c/111398/
> 
> 
> Diffs
> -----
> 
>   lib/document/loadingdocumentimpl.cpp cc8bea9 
> 
> Diff: https://git.reviewboard.kde.org/r/123906/diff/
> 
> 
> Testing
> -------
> 
> opened rotated and non-rotated images
> 
> 
> Thanks,
> 
> Lukas Hetzenecker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20150526/d3312597/attachment.html>