Review Request 123906: Fix for "Some images rotated via EXIF are not rotated and appear in the wrong size" - BUG 343044

[Lukas Hetzenecker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123906/
-----------------------------------------------------------

Review request for Gwenview.


Bugs: 343044
    http://bugs.kde.org/show_bug.cgi?id=343044


Repository: gwenview


Description
-------

I tracked down this bug and made the following observations:

It was caused by QTBUG-37946 ( https://bugreports.qt.io/browse/QTBUG-37946 ):

Starting with Qt 5.4 (which Ubuntu and Arch are shipping), QImage automatically checks if there is an Exif header present and rotates the images accordingly. - see this change: https://codereview.qt-project.org/#/c/98013/

But this behavior will be reverted in the soon released Qt 5.4.2, because it is backwards incompatible and breaks existing applications (like this one here ;) ) - see this change: https://codereview.qt-project.org/#/c/111398/


Diffs
-----

  lib/document/loadingdocumentimpl.cpp cc8bea9 

Diff: https://git.reviewboard.kde.org/r/123906/diff/


Testing
-------

opened rotated and non-rotated images


Thanks,

Lukas Hetzenecker

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20150526/b2f70420/attachment.html>