Review Request 124088: Remove unused dependencies.
Michael Palimaka
kensington at gentoo.org
Fri Jun 12 19:10:53 UTC 2015
> On June 12, 2015, 7:09 p.m., Vishesh Handa wrote:
> > tests/CMakeLists.txt, line 9
> > <https://git.reviewboard.kde.org/r/124088/diff/1/?file=379783#file379783line9>
> >
> > I'm a little surprised that the manual tests require QtTest, but maybe that can be improver later.
Me too, but it turns out to use qsignalspy.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124088/#review81425
-----------------------------------------------------------
On June 12, 2015, 6:26 p.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124088/
> -----------------------------------------------------------
>
> (Updated June 12, 2015, 6:26 p.m.)
>
>
> Review request for Gwenview.
>
>
> Repository: gwenview
>
>
> Description
> -------
>
> I can't find any reference to Qt5DBus or Qt5Script, so remove them. Qt5Test is used only by tests/, so don't find it twice.
>
>
> Diffs
> -----
>
> CMakeLists.txt 2d2ab8d5594421cf4539db3e30425b1b11ef14be
> tests/CMakeLists.txt a8a2913ca0fce5f58952373527d838a89f64cdfb
> tests/auto/CMakeLists.txt 5a4915187f9a4cf72424e9bd51183bfede39a3e6
>
> Diff: https://git.reviewboard.kde.org/r/124088/diff/
>
>
> Testing
> -------
>
> Inspected source and binary output. Builds.
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20150612/87bfeac3/attachment.html>
More information about the Gwenview-devel
mailing list