Review Request 124088: Remove unused dependencies.

Vishesh Handa me at vhanda.in
Fri Jun 12 19:09:54 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124088/#review81425
-----------------------------------------------------------

Ship it!


Looks good.


tests/CMakeLists.txt (line 9)
<https://git.reviewboard.kde.org/r/124088/#comment55799>

    I'm a little surprised that the manual tests require QtTest, but maybe that can be improver later.


- Vishesh Handa


On June 12, 2015, 6:26 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124088/
> -----------------------------------------------------------
> 
> (Updated June 12, 2015, 6:26 p.m.)
> 
> 
> Review request for Gwenview.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> I can't find any reference to Qt5DBus or Qt5Script, so remove them. Qt5Test is used only by tests/, so don't find it twice.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2d2ab8d5594421cf4539db3e30425b1b11ef14be 
>   tests/CMakeLists.txt a8a2913ca0fce5f58952373527d838a89f64cdfb 
>   tests/auto/CMakeLists.txt 5a4915187f9a4cf72424e9bd51183bfede39a3e6 
> 
> Diff: https://git.reviewboard.kde.org/r/124088/diff/
> 
> 
> Testing
> -------
> 
> Inspected source and binary output. Builds.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20150612/0f61b674/attachment.html>


More information about the Gwenview-devel mailing list