Review Request 121140: Make Baloo detection and usage more subtle

[Lukáš Tinkl]

> On Lis. 19, 2014, 6:50 odp., Hrvoje Senjan wrote:
> > ping-pong
> > this is really a small patch, at least reviewing whether direction is ok would be cool. tnx!

+1 from me, I'd rather wait for Vishesh to comment on the current baloo situation


- Lukáš


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121140/#review70661
-----------------------------------------------------------


On Lis. 17, 2014, 3:59 odp., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121140/
> -----------------------------------------------------------
> 
> (Updated Lis. 17, 2014, 3:59 odp.)
> 
> 
> Review request for Gwenview, David Edmundson, Lukáš Tinkl, and Vishesh Handa.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> at the moment we have slightly messy situation.
> there is baloo/5.1, and baloo master. we know gwenview will not build with < 5.1.90, that is master.
> also resolved the old problem when user would select baloo backend, but it wasn't found, thus the build would fail in the middle.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 928cbb1 
>   lib/CMakeLists.txt ec64b24 
> 
> Diff: https://git.reviewboard.kde.org/r/121140/diff/
> 
> 
> Testing
> -------
> 
> inspected config-gwenview.h after passing various options (and locally raising required baloo version to 5.1.91)
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20141119/47c2cc28/attachment.html>