Review Request 111362: Do not treat .svgz as archives + fix directory not loaded when started with a .svg as argument

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111362/
-----------------------------------------------------------

(Updated Aug. 6, 2013, 6:24 p.m.)


Status
------

This change has been marked as submitted.


Review request for Gwenview.


Description
-------

This patch does two things:

1. It adds a special case to ArchiveUtils::protocolForMimeType() so that .svgz are not treated as archives
2. It fixes the behavior of SvgImageView::loadFromDocument() so that it works even if the document is not yet fully loaded

#1 is needed so that clicking on an svgz from browse mode does not trigger an error dialog saying url cannot be read.

#2 is needed because right now opening an svgz from the command line causes the url to be turned from file:///home/foo/bar.svgz into gzip:///home/foo/bar.svgz. This is actually a bug I am going to address, but the fix is nevertheless useful when browsing remote urls, since they are treated the same as urls whose protocol is "gzip".


This addresses bugs 207115 and 321825.
    http://bugs.kde.org/show_bug.cgi?id=207115
    http://bugs.kde.org/show_bug.cgi?id=321825


Diffs
-----

  lib/archiveutils.cpp 65a010e063ec8086d9a1443f2774f7d56a2fabd0 
  lib/documentview/svgviewadapter.h af43abaa3b523416ae0ce58054fe6367ed06be95 
  lib/documentview/svgviewadapter.cpp 1ec57fe54b241b6cc2776febd1b7f03b81753c14 

Diff: http://git.reviewboard.kde.org/r/111362/diff/


Testing
-------

Opened svg and svgz files without problems, both local and remote (thumbnails are broken for svg on remote urls, but that's yet another bug).


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20130806/8380e7d7/attachment.html>