<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111362/">http://git.reviewboard.kde.org/r/111362/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Gwenview.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Aug. 6, 2013, 6:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch does two things:
1. It adds a special case to ArchiveUtils::protocolForMimeType() so that .svgz are not treated as archives
2. It fixes the behavior of SvgImageView::loadFromDocument() so that it works even if the document is not yet fully loaded
#1 is needed so that clicking on an svgz from browse mode does not trigger an error dialog saying url cannot be read.
#2 is needed because right now opening an svgz from the command line causes the url to be turned from file:///home/foo/bar.svgz into gzip:///home/foo/bar.svgz. This is actually a bug I am going to address, but the fix is nevertheless useful when browsing remote urls, since they are treated the same as urls whose protocol is "gzip".
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Opened svg and svgz files without problems, both local and remote (thumbnails are broken for svg on remote urls, but that's yet another bug).</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=207115">207115</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=321825">321825</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/archiveutils.cpp <span style="color: grey">(65a010e063ec8086d9a1443f2774f7d56a2fabd0)</span></li>
<li>lib/documentview/svgviewadapter.h <span style="color: grey">(af43abaa3b523416ae0ce58054fe6367ed06be95)</span></li>
<li>lib/documentview/svgviewadapter.cpp <span style="color: grey">(1ec57fe54b241b6cc2776febd1b7f03b81753c14)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111362/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>