Review Request: Allow scene-global scripts

Arjen Hiemstra djfreestyler at gmail.com
Fri Mar 16 22:36:18 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104273/#review11495
-----------------------------------------------------------

Ship it!


Looks fine to me. One addition to make later on is to filter the components that are allowed on the root object.

- Arjen Hiemstra


On March 14, 2012, 6:47 p.m., Tirtha Chatterjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104273/
> -----------------------------------------------------------
> 
> (Updated March 14, 2012, 6:47 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> This patch exposes the scene's gameobject tree root in the SceneModel.
> It makes it possible to add scripts specific to scenes, which are executed at the start of scenes.
> 
> 
> Diffs
> -----
> 
>   creator/lib/models/scenemodel.cpp cbbefe0 
> 
> Diff: http://git.reviewboard.kde.org/r/104273/diff/
> 
> 
> Testing
> -------
> 
> No tests written. Manually tested, and works.
> 
> 
> Thanks,
> 
> Tirtha Chatterjee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20120316/174b8ebe/attachment.html>


More information about the Gluon mailing list