Review Request: gani's GSoC work

[Felix Rohrbach]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107946/#review24056
-----------------------------------------------------------


A few things I saw when looking through the code


engine/components/other/physics/physicsworld.cpp
<http://git.reviewboard.kde.org/r/107946/#comment18356>

    Maybe I'm just missing some C++-Knowlegde here, but I don't quite understand what this does. A function declaration in a function, but no definition?



engine/components/other/physics/physicsworld.cpp
<http://git.reviewboard.kde.org/r/107946/#comment18357>

    Why do you delete what you have just created? I don't understand the sense of this class currently...



player/examples/invaders.gluon/game.gluonmeta
<http://git.reviewboard.kde.org/r/107946/#comment18358>

    Maybe this should be reverted


- Felix Rohrbach


On Dec. 27, 2012, 2:28 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107946/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2012, 2:28 p.m.)
> 
> 
> Review request for Gluon and Ganeshprasad Tumkur Paramashivaiah.
> 
> 
> Description
> -------
> 
> This is gani's summer of code work (branch engine-physicscollisions-gani), adding collusions with the bullet library. I rebased the code and did some simple cleanup (whitespace, .directory-files). Note that you need bullet version 2.80, as 2.81 (at least) is source incompatible.
> 
> 
> Diffs
> -----
> 
>   engine/CMakeLists.txt eb86717 
>   engine/cmake/FindGluonEngine.cmake cd166d0 
>   engine/components/CMakeLists.txt 527d5c7 
>   engine/components/other/physics/CMakeLists.txt PRE-CREATION 
>   engine/components/other/physics/boxcollisioncomponent.h PRE-CREATION 
>   engine/components/other/physics/boxcollisioncomponent.cpp PRE-CREATION 
>   engine/components/other/physics/physicsworld.h PRE-CREATION 
>   engine/components/other/physics/physicsworld.cpp PRE-CREATION 
>   engine/components/other/physics/spherecollisioncomponent.h PRE-CREATION 
>   engine/components/other/physics/spherecollisioncomponent.cpp PRE-CREATION 
>   engine/components/other/spherecollision/spherecollisioncomponent.cpp ef12869 
>   engine/gluon_engine_export.h f661f69 
>   player/examples/invaders.gluon/.directory 8b3d81a 
>   player/examples/invaders.gluon/game.gluonmeta 4d463de 
>   player/examples/invaders.gluon/game.gluonproject 3a57a72 
>   player/examples/invaders.gluon/game.ico 1c01be8 
> 
> Diff: http://git.reviewboard.kde.org/r/107946/diff/
> 
> 
> Testing
> -------
> 
> Only compiling
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20121227/bd328557/attachment.html>