Review Request: Bounding boxes for 2 components

Arjen Hiemstra djfreestyler at gmail.com
Sat Dec 1 14:24:07 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106713/#review22865
-----------------------------------------------------------



engine/components/graphics/animatedspriterenderer/animatedspriterenderercomponent.cpp
<http://git.reviewboard.kde.org/r/106713/#comment17444>

    Why the qCeil calls? Bounding boxes should also be able to handle float sizes.


- Arjen Hiemstra


On Oct. 3, 2012, 4:08 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106713/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2012, 4:08 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> Add bounding boxes for {Animated,}SpriteRendererComponent.
> 
> 
> Diffs
> -----
> 
>   engine/components/graphics/animatedspriterenderer/animatedspriterenderercomponent.h 87504a8 
>   engine/components/graphics/animatedspriterenderer/animatedspriterenderercomponent.cpp 5fb7d60 
>   engine/components/graphics/spriterenderer/spriterenderercomponent.h dd9d694 
>   engine/components/graphics/spriterenderer/spriterenderercomponent.cpp 4e5c8f5 
> 
> Diff: http://git.reviewboard.kde.org/r/106713/diff/
> 
> 
> Testing
> -------
> 
> Compiles
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20121201/025153d7/attachment.html>


More information about the Gluon mailing list