Review Request: Bounding boxes for GameObjects

[Arjen Hiemstra]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106712/#review22864
-----------------------------------------------------------



core/axisalignedbox.cpp
<http://git.reviewboard.kde.org/r/106712/#comment17442>

    Just as an aside comment, it would probably be a good idea to make the BB class a shared data class. Might want to add a TODO about that somewhere.



engine/gameobject.cpp
<http://git.reviewboard.kde.org/r/106712/#comment17441>

    Please add a TODO here that this really should be cached. We currently lack a signal in components/children to notify of bounding box changes but that is what should be done: listen for bounding box changes on children and if it changes, invalidate the bounding box so it can be recalculated when necessary.



engine/gameobject.cpp
<http://git.reviewboard.kde.org/r/106712/#comment17443>

    There really should be an in-place way of doing this. Right now you are creating a new BB for each call that simply gets destroyed again once the assignment is performed. This is quite unneccessary and only slows down things.


- Arjen Hiemstra


On Oct. 3, 2012, 1:24 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106712/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2012, 1:24 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> This adds bounding boxes for GameObjects, based on the patch for Components. I'm not really sure if the rotation works, as I don't have much experience in graphics.
> 
> 
> Diffs
> -----
> 
>   core/axisalignedbox.h 5d9cab1 
>   core/axisalignedbox.cpp 9e7e3eb 
>   engine/gameobject.h c042e94 
>   engine/gameobject.cpp a0d059f 
> 
> Diff: http://git.reviewboard.kde.org/r/106712/diff/
> 
> 
> Testing
> -------
> 
> Compiles (x86_64, Qt 4.8.3)
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20121201/b58dd325/attachment.html>