Review Request: Add functions to get the size of a component

Laszlo Papp lpapp at kde.org
Fri Aug 24 13:26:37 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106047/#review17945
-----------------------------------------------------------



core/axisalignedbox.cpp
<http://git.reviewboard.kde.org/r/106047/#comment14175>

    Instead of making them (value and minima) consistent, perhaps you could just be consistent with the global operator descriptions here which take two QVector3D arguments:
    
    http://doc-snapshot.qt-project.org/4.8/qvector3d.html#operator-2b-8


- Laszlo Papp


On Aug. 22, 2012, 8 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106047/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2012, 8 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> I'd like to have these functions to compute the size of GameObjects.
> 
> 
> Diffs
> -----
> 
>   core/CMakeLists.txt 3d94d84 
>   core/axisalignedbox.h PRE-CREATION 
>   core/axisalignedbox.cpp PRE-CREATION 
>   engine/component.h db86220 
>   engine/component.cpp 2999d84 
> 
> Diff: http://git.reviewboard.kde.org/r/106047/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20120824/983f4115/attachment.html>


More information about the Gluon mailing list