Review Request: Add functions to get the size of a component

Laszlo Papp lpapp at kde.org
Thu Aug 23 18:57:41 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106047/#review17916
-----------------------------------------------------------


While it is known that gluoncore already depends on the Qt ui module, we have got one additional (QVector3D) now. Perhaps, the QPoint3D integration will solve such issues like this in the long future. This comment is only informational, and not meant for getting anything changed.


core/axisalignedbox.h
<http://git.reviewboard.kde.org/r/106047/#comment14137>

    Perhaps, you can just delete this method for now, as it is not used. Can be added later, when the need arises.


- Laszlo Papp


On Aug. 22, 2012, 8 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106047/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2012, 8 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> I'd like to have these functions to compute the size of GameObjects.
> 
> 
> Diffs
> -----
> 
>   core/CMakeLists.txt 3d94d84 
>   core/axisalignedbox.h PRE-CREATION 
>   core/axisalignedbox.cpp PRE-CREATION 
>   engine/component.h db86220 
>   engine/component.cpp 2999d84 
> 
> Diff: http://git.reviewboard.kde.org/r/106047/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20120823/dc80dfee/attachment.html>


More information about the Gluon mailing list