Review Request: Achievements 15: A better UI for Achievements in the KDE Extended player.

[Laszlo Papp]

> On Oct. 31, 2011, 6:14 p.m., Laszlo Papp wrote:
> > There is a post-sprint implementation ongoing I started in Munich. You might need to rebase this patch on top of those patches, but it should not be a big work since it is mostly just about transferring. I will put you into the CC field of those patches, and you can get easily notified. It should not be more than 1-2 days from now on. I have not unfortunately had too much time to review this patch in details because of my deadlines and personal issues. It seems okay to me for a fast skim, though. I do not object to it, but please wait for the ongoing work first.
> 
> Laszlo Papp wrote:
>     Okay, mostly done. I have had quite a few commits 1-2 hours ago, but this might be the relevant for you:
>     https://projects.kde.org/projects/playground/games/gluon/repository/revisions/198b0c0eeb5c44fd8cae5d720f7631ac89ebea53
>     
>     I have not changed the content of the kde ext player. It is just a simple renaming and move in that regard.

It is even more accurate:
https://projects.kde.org/projects/playground/games/gluon/repository/revisions/b2bc6d1211b2979e3d40fafb231401d01a64c89d


- Laszlo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102987/#review7778
-----------------------------------------------------------


On Oct. 29, 2011, 1:25 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102987/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2011, 1:25 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> As the title says. There will be more changes of the UI in later commits, so it wouldn't make much sense to discuss now about the look of the achievements tab in the player.
> 
> 
> Diffs
> -----
> 
>   engine/achievement.cpp 021ee24 
>   engine/achievementsmanager.h 1e9e24d 
>   engine/achievementsmanager.cpp e08a05d 
>   player/kdeext/CMakeLists.txt 01cd3ee 
>   player/kdeext/delegates/achievementdelegate.h PRE-CREATION 
>   player/kdeext/delegates/achievementdelegate.cpp PRE-CREATION 
>   player/kdeext/gamedetailsoverlay.h dd95f2a 
>   player/kdeext/gamedetailsoverlay.cpp ca0d6a8 
>   player/lib/models/achievementsmodel.h c25c1f9 
>   player/lib/models/achievementsmodel.cpp 34000ff 
> 
> Diff: http://git.reviewboard.kde.org/r/102987/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111102/46e05af3/attachment.html>