<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102987/">http://git.reviewboard.kde.org/r/102987/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 31st, 2011, 6:14 p.m., <b>Laszlo Papp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is a post-sprint implementation ongoing I started in Munich. You might need to rebase this patch on top of those patches, but it should not be a big work since it is mostly just about transferring. I will put you into the CC field of those patches, and you can get easily notified. It should not be more than 1-2 days from now on. I have not unfortunately had too much time to review this patch in details because of my deadlines and personal issues. It seems okay to me for a fast skim, though. I do not object to it, but please wait for the ongoing work first.</pre>
</blockquote>
<p>On November 1st, 2011, 4:30 a.m., <b>Laszlo Papp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okay, mostly done. I have had quite a few commits 1-2 hours ago, but this might be the relevant for you:
https://projects.kde.org/projects/playground/games/gluon/repository/revisions/198b0c0eeb5c44fd8cae5d720f7631ac89ebea53
I have not changed the content of the kde ext player. It is just a simple renaming and move in that regard.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It is even more accurate:
https://projects.kde.org/projects/playground/games/gluon/repository/revisions/b2bc6d1211b2979e3d40fafb231401d01a64c89d</pre>
<br />
<p>- Laszlo</p>
<br />
<p>On October 29th, 2011, 1:25 p.m., Felix Rohrbach wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Gluon.</div>
<div>By Felix Rohrbach.</div>
<p style="color: grey;"><i>Updated Oct. 29, 2011, 1:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As the title says. There will be more changes of the UI in later commits, so it wouldn't make much sense to discuss now about the look of the achievements tab in the player.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>engine/achievement.cpp <span style="color: grey">(021ee24)</span></li>
<li>engine/achievementsmanager.h <span style="color: grey">(1e9e24d)</span></li>
<li>engine/achievementsmanager.cpp <span style="color: grey">(e08a05d)</span></li>
<li>player/kdeext/CMakeLists.txt <span style="color: grey">(01cd3ee)</span></li>
<li>player/kdeext/delegates/achievementdelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>player/kdeext/delegates/achievementdelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>player/kdeext/gamedetailsoverlay.h <span style="color: grey">(dd95f2a)</span></li>
<li>player/kdeext/gamedetailsoverlay.cpp <span style="color: grey">(ca0d6a8)</span></li>
<li>player/lib/models/achievementsmodel.h <span style="color: grey">(c25c1f9)</span></li>
<li>player/lib/models/achievementsmodel.cpp <span style="color: grey">(34000ff)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102987/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>