Review Request: Achievements 5: AchievementsModel

[Felix Rohrbach]

> On July 24, 2011, 4:46 p.m., Laszlo Papp wrote:
> > player/lib/models/achievementsmodel.cpp, line 73
> > <http://git.reviewboard.kde.org/r/102033/diff/3/?file=29671#file29671line73>
> >
> >     1) You immediately return here, if there it is not passed by DisplayRole. The problem is that icons and so forth might be better to handle by DecorationRole.
> >     
> >     2) I would actually keep also the text fallback way and also the icon way meaning that I would use DecorationRole and DisplayRole as well.

2: Fallback won't work, as if there is a DecorationRole and a DisplayRole, the Qt views will show both.


> On July 24, 2011, 4:46 p.m., Laszlo Papp wrote:
> > player/lib/models/achievementsmodel.cpp, line 26
> > <http://git.reviewboard.kde.org/r/102033/diff/3/?file=29671#file29671line26>
> >
> >     The player library is pure Qt.

Oh, right, just forgot to remove this one after I noticed that, too.


- Felix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102033/#review5042
-----------------------------------------------------------


On July 24, 2011, 4:03 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102033/
> -----------------------------------------------------------
> 
> (Updated July 24, 2011, 4:03 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Add a first version of a AchievementsModel, which will show the Achievements to the user.
> 
> 
> Diffs
> -----
> 
>   engine/achievement.cpp 13e4f14 
>   player/lib/CMakeLists.txt 24c9164 
>   player/lib/models/achievementsmodel.h PRE-CREATION 
>   player/lib/models/achievementsmodel.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102033/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110724/dda7169d/attachment.htm