Review Request: Achievements 5: AchievementsModel

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102033/#review5042
-----------------------------------------------------------



player/lib/models/achievementsmodel.cpp
<http://git.reviewboard.kde.org/r/102033/#comment4467>

    The player library is pure Qt.



player/lib/models/achievementsmodel.cpp
<http://git.reviewboard.kde.org/r/102033/#comment4468>

    1) You seem to miss the "%1" part
    
    2) I would probably use qDebug() << Q_FUNC_INFO << QString("No GameProject open!");or something like that, but if you add the missing "%1" part, I am also fine with that.



player/lib/models/achievementsmodel.cpp
<http://git.reviewboard.kde.org/r/102033/#comment4471>

    1) You immediately return here, if there it is not passed by DisplayRole. The problem is that icons and so forth might be better to handle by DecorationRole.
    
    2) I would actually keep also the text fallback way and also the icon way meaning that I would use DecorationRole and DisplayRole as well.



player/lib/models/achievementsmodel.cpp
<http://git.reviewboard.kde.org/r/102033/#comment4469>

    As far as I can see, there is no need for this temporary variable. You can return the icons directly.



player/lib/models/achievementsmodel.cpp
<http://git.reviewboard.kde.org/r/102033/#comment4470>

    delete this line


- Laszlo


On July 24, 2011, 4:03 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102033/
> -----------------------------------------------------------
> 
> (Updated July 24, 2011, 4:03 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Add a first version of a AchievementsModel, which will show the Achievements to the user.
> 
> 
> Diffs
> -----
> 
>   engine/achievement.cpp 13e4f14 
>   player/lib/CMakeLists.txt 24c9164 
>   player/lib/models/achievementsmodel.h PRE-CREATION 
>   player/lib/models/achievementsmodel.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102033/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110724/2ad56851/attachment-0001.htm