Review Request: Achievements 4: GameProject::achievements()
Felix Rohrbach
fxrh at gmx.de
Wed Jul 13 20:28:57 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101933/
-----------------------------------------------------------
(Updated July 13, 2011, 6:28 p.m.)
Review request for Gluon.
Changes
-------
Now I found a way where I don't need to call the findAchievements method anymore. This patch depends now on Achievements 3, though.
How it works: Now, every achievement registers or unregisters at the GameProject. The registration happens in the sanitize() method (as this is the place where we can get the GameProject), the unregistration in the destructor of the Achievement class.
Summary
-------
Create a function that returns a list of all achievements of a GameProject.
Diffs (updated)
-----
engine/achievement.h 79337b1
engine/achievement.cpp 53a6917
engine/assets/other/achievements/achievementsasset.cpp PRE-CREATION
engine/gameproject.h 805d193
engine/gameproject.cpp 8d84024
engine/gameprojectprivate.h 38c442a
engine/gameprojectprivate.cpp 08424b1
Diff: http://git.reviewboard.kde.org/r/101933/diff
Testing
-------
Thanks,
Felix
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110713/bfd31bf0/attachment.htm
More information about the Gluon
mailing list