Review Request: Achievements 4: GameProject::achievements()

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101933/#review4667
-----------------------------------------------------------


Just for book keeping what I asked on IRC and then we discussed: Please describe why you cannot use simple setter with internal storage. Hence there would be a setter/getter/append/find if all of them are needed. I do not know the design that well, but going through the things all the time when a getter occurs seems to be a bit weird at first glance in theory instead of internal ptr list or something like that. It might be not possible, but then please try to explain it why, so that we can understand.

- Laszlo


On July 12, 2011, 5:57 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101933/
> -----------------------------------------------------------
> 
> (Updated July 12, 2011, 5:57 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Create a function that returns a list of all achievements of a GameProject.
> 
> 
> Diffs
> -----
> 
>   engine/gameproject.h 805d193 
>   engine/gameproject.cpp 8d84024 
>   engine/gameprojectprivate.h 38c442a 
>   engine/gameprojectprivate.cpp 08424b1 
> 
> Diff: http://git.reviewboard.kde.org/r/101933/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110713/68d01524/attachment.htm