Review Request: Achievements 2: LongLongPropertyWidgetItem

[Laszlo Papp]

> On July 10, 2011, 11:11 p.m., Laszlo Papp wrote:
> > creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.cpp, line 70
> > <http://git.reviewboard.kde.org/r/101908/diff/2/?file=26674#file26674line70>
> >
> >     Mmm, I told on IRC that, I think it might be a good idea to report the issue with a gluon debug message if the conversion somehow failed. It should not fail with the proper range value, but a conditional debug message should not hurt in order to make the library more talkative in case of errors.
> 
> Felix Rohrbach wrote:
>     What do you mean with gluon debug messages? Those which appear in the creator messages dock? If yes, how do I create those messages from objects which not inherit from GluonObject?

1) It is not just about the creator messages dock, but yes, also there, also on console.
2) It has nothing to do with GluonObject, it is a debug opportunity like qDebug() or kDebug(), but with our idea. You just need to include the relevant header and use it. :)

#include <core/debughelper.h>

and look at this usage for sample:
https://projects.kde.org/projects/playground/games/gluon/repository/revisions/master/entry/creator/lib/models/scenemodel.cpp#L271


- Laszlo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101908/#review4581
-----------------------------------------------------------


On July 10, 2011, 10:48 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101908/
> -----------------------------------------------------------
> 
> (Updated July 10, 2011, 10:48 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Add a PropertyWidgetItem to edit qlonglong values in the creator. Needed by the Achievement class.
> 
> 
> Diffs
> -----
> 
>   creator/plugins/docks/propertiesdock/CMakeLists.txt 05c5242 
>   creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.h PRE-CREATION 
>   creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101908/diff
> 
> 
> Testing
> -------
> 
> Tested with the Achievement and Statistic class. When the value is out of the limit, it is set to 0.
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110711/a1b135a2/attachment.htm