<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101908/">http://git.reviewboard.kde.org/r/101908/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 10th, 2011, 11:11 p.m., <b>Laszlo Papp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101908/diff/2/?file=26674#file26674line70" style="color: black; font-weight: bold; text-decoration: underline;">creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void LongLongPropertyWidgetItem::stringValueChanged( QString value )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">70</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">qlonglong</span> <span class="n">number</span> <span class="o">=</span> <span class="n">value</span><span class="p">.</span><span class="n">toLongLong</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Mmm, I told on IRC that, I think it might be a good idea to report the issue with a gluon debug message if the conversion somehow failed. It should not fail with the proper range value, but a conditional debug message should not hurt in order to make the library more talkative in case of errors.</pre>
</blockquote>
<p>On July 11th, 2011, 12:06 p.m., <b>Felix Rohrbach</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What do you mean with gluon debug messages? Those which appear in the creator messages dock? If yes, how do I create those messages from objects which not inherit from GluonObject?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) It is not just about the creator messages dock, but yes, also there, also on console.
2) It has nothing to do with GluonObject, it is a debug opportunity like qDebug() or kDebug(), but with our idea. You just need to include the relevant header and use it. :)
#include <core/debughelper.h>
and look at this usage for sample:
https://projects.kde.org/projects/playground/games/gluon/repository/revisions/master/entry/creator/lib/models/scenemodel.cpp#L271
</pre>
<br />
<p>- Laszlo</p>
<br />
<p>On July 10th, 2011, 10:48 p.m., Felix Rohrbach wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Gluon.</div>
<div>By Felix Rohrbach.</div>
<p style="color: grey;"><i>Updated July 10, 2011, 10:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a PropertyWidgetItem to edit qlonglong values in the creator. Needed by the Achievement class.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with the Achievement and Statistic class. When the value is out of the limit, it is set to 0.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>creator/plugins/docks/propertiesdock/CMakeLists.txt <span style="color: grey">(05c5242)</span></li>
<li>creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101908/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>