Review Request: Use invokeMethod to call job slots instead of emitting a signal

[Shantanu Tushar Jha]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101879/
-----------------------------------------------------------

Review request for Gluon.


Summary
-------

When I saw Arjen's comment on the start*ing signals Laszlo devised to call the Job slots when the provider was ready, I suddenly realised that its better to use QMetaObject::invokeMethod to call the slots, instead of emitting a signal whose sole purpose was to call the slot immediately. invokeMethod does all that in one line :)
(Also fixed few slot name hiccups, no idea when that happened)


Diffs
-----

  player/lib/gamedetaillistjob.cpp 8b7d52c 
  player/lib/models/gameitemsmodel.cpp 49f77ee 
  player/lib/serviceprovider.h 1bf179d 
  player/lib/serviceprovider.cpp 97889b3 

Diff: http://git.reviewboard.kde.org/r/101879/diff


Testing
-------

Tested for fetchGames, works.


Thanks,

Shantanu Tushar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110708/5c8317e5/attachment.htm