Review Request: Add Category and NewGame classes

Shantanu Tushar Jha jhahoneyk at gmail.com
Mon Jul 4 17:23:39 CEST 2011


Hi,

There was some network problem and Reviewboard forgot the description for
the new diff, it reads -

"Renamed to AddGameJob. Renamed slots as discussed on IRC (point out
mistakes, if any). Initialised pointers to null. Removed "New" term."

Cheers,

Shantanu Tushar    (UTC +0530)
http://www.shantanutushar.com


On Mon, Jul 4, 2011 at 8:49 PM, Shantanu Tushar Jha <jhahoneyk at gmail.com>wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101816/
>   Review request for Gluon.
> By Shantanu Tushar Jha.
>
> *Updated July 4, 2011, 3:19 p.m.*
> Description
>
> Category's job is to fetch list of categories from the server.
> NewGame takes a game name and a category, and then creates a new game on the server, returning the ID of newly created game.
>
>   Testing
>
> Both classes function as expected when used.
>
>   Diffs (updated)
>
>    - player/lib/CMakeLists.txt (53c0f0a)
>    - player/lib/addgamejob.h (PRE-CREATION)
>    - player/lib/addgamejob.cpp (PRE-CREATION)
>    - player/lib/categorylistjob.h (PRE-CREATION)
>    - player/lib/categorylistjob.cpp (PRE-CREATION)
>
> View Diff <http://git.reviewboard.kde.org/r/101816/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110704/c4b9d0e7/attachment.htm 


More information about the Gluon mailing list