Hi,<br><br>There was some network problem and Reviewboard forgot the description for the new diff, it reads -<br><br>"Renamed to AddGameJob. Renamed slots as discussed on IRC (point out mistakes, if any). Initialised pointers to null. Removed "New" term."<br>
<br>Cheers,<br clear="all"><div><br></div>Shantanu Tushar (UTC +0530)<br><a href="http://www.shantanutushar.com" target="_blank">http://www.shantanutushar.com</a><br>
<br><br><div class="gmail_quote">On Mon, Jul 4, 2011 at 8:49 PM, Shantanu Tushar Jha <span dir="ltr"><<a href="mailto:jhahoneyk@gmail.com">jhahoneyk@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div>
<div style="font-family:Verdana, Arial, Helvetica, Sans-Serif"><div class="im">
<table style="border:1px #c9c399 solid" bgcolor="#f9f3c9" cellpadding="8" width="100%">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101816/" target="_blank">http://git.reviewboard.kde.org/r/101816/</a>
</td>
</tr>
</tbody></table>
<br>
</div><table style="background-repeat:repeat-x;border:1px black solid" bgcolor="#fefadf" cellpadding="8" cellspacing="0" width="100%">
<tbody><tr>
<td><div class="im">
<div>Review request for Gluon.</div>
<div>By Shantanu Tushar Jha.</div>
</div><p style="color:grey"><i>Updated July 4, 2011, 3:19 p.m.</i></p><div class="im">
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Category's job is to fetch list of categories from the server.
NewGame takes a game name and a category, and then creates a new game on the server, returning the ID of newly created game.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Both classes function as expected when used.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs (updated)</h1>
</div><ul style="margin-left:3em;padding-left:0"><div class="im">
<li>player/lib/CMakeLists.txt <span style="color:grey">(53c0f0a)</span></li>
</div><li>player/lib/addgamejob.h <span style="color:grey">(PRE-CREATION)</span></li>
<li>player/lib/addgamejob.cpp <span style="color:grey">(PRE-CREATION)</span></li><div class="im">
<li>player/lib/categorylistjob.h <span style="color:grey">(PRE-CREATION)</span></li>
<li>player/lib/categorylistjob.cpp <span style="color:grey">(PRE-CREATION)</span></li>
</div></ul>
<p><a href="http://git.reviewboard.kde.org/r/101816/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div>
</div>
</blockquote></div><br>